-
-
Notifications
You must be signed in to change notification settings - Fork 10.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
various: add rosetta caveats [0-9a-c] #178000
Conversation
Some spurious failures related to Homebrew/brew#17573
even with
|
The |
cba99c6
to
9e667d5
Compare
That Amazon Music app probably would be compatible with rosetta but they have that weird install script causing problems. I've removed the change from this PR. Also reverted change to |
Please split this in one commit per cask. |
I really would rather not. Why? |
It is standard practice in all Homebrew repositories, it keep commit history cleaner and makes it easier to revert individual changes as required. |
I see, thanks for clarifying. |
9e667d5
to
560da37
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @wickles ! Without contributions like yours it'd be impossible to keep homebrew going with the high standards that users have come to expect from the project. You can feel good knowing that you've made the world a tiny bit better for homebrew users around the world! 👍 🎉
Partial test/followup for #177913 (part 1)